Something that wasn't tested back then, or is this problem connected Obviously the *hardware* hasn't changed since 1df5172c5c25. > Thus, add a check for s2idle to the quirk, and do nothing if the suspend > mode is s2idle. I would feelīetter about this if we understood what the difference was. IIUC this change will reduce the s2idle power savings. Something special about s2idle that prevents the power-on. 'power is automatically restored before resume,' so there must be ('PCI: Suspend/resume quirks for Apple thunderbolt'). Quirk_apple_poweroff_thunderbolt() was added in 2014 by 1df5172c5c25 The reason turned out that the hw that the quirk > powers off does not get powered on back on resume. > On Macbook 2013 resuming from s2idle results in external monitor no > longer being detected, and dmesg having errors like: > pcieport 0000:06:00.0: can't change power state from D3hot to D0 (config space inaccessible) > and a stacktrace. On Thu, at 08:38:20PM +0300, Konstantin Kharlamov wrote: X-Mailing-List: don't power-off apple thunderbolt controller on s2idleījorn Helgaas May 6, 2021, 9:48 p.m. To: PCI: don't power-off apple thunderbolt controller on s2idle ( )īy (mxback/Yandex) with ESMTP idĭKIM-Signature: v=1 a=rsa-sha256 c=relaxed/relaxed d= s=mail īh=0oTNph2dZC4eU/f0xJby8Sol/6DD5xZ3ZIoc3TSMnG0= ī=tgEQayaCcuPkSmgPu2976zOCyne1f5CEqh7aRb84Q2JHSV03Bb8q26lrObi9GyDufīIRJg79u8KunnHrGmw6W8XFgfj/9q8/zAwE1xmEMqb4EZLir6vyA7TVA+XVgNrF25GĨqEHrSkW/MdUaqUjkfS8Bb94yi6Addhj7BTU7kuY=Īuthentication-Results: ĭkim=pass by (smtp/Yandex) with ESMTPSA Received: from (īy (Postfix) with ESMTPS id B7AA0C061574 X-Greylist: delayed 312 seconds by postgrey-1.37 at Received: from ( )īy (Postfix) with ESMTP id EF62C610CE Received: from ( )īy (Postfix) with ESMTP id 27D52C433B4 MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED,ĭKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,

X-Spam-Checker-Version: SpamAssassin 3.4.0 () onĪ

Target disk mode thunderbolt 2 to 3